Skip to content

seafile-client: switch from qt5 to qt6#442070

Merged
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:tmp-fix-seafile-client-1757604728
Sep 11, 2025
Merged

seafile-client: switch from qt5 to qt6#442070
pbsds merged 1 commit intoNixOS:masterfrom
pbsds:tmp-fix-seafile-client-1757604728

Conversation

@pbsds
Copy link
Member

@pbsds pbsds commented Sep 11, 2025

fixes #442063

@padhia please test

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

Add a 👍 reaction to pull requests you find important.

@pbsds pbsds mentioned this pull request Sep 11, 2025
3 tasks
@pbsds pbsds force-pushed the tmp-fix-seafile-client-1757604728 branch from 8f5b848 to e9d2ecd Compare September 11, 2025 15:49
@nixpkgs-ci nixpkgs-ci bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Sep 11, 2025
@nix-owners nix-owners bot requested a review from schmittlauch September 11, 2025 15:55
@melvyn2
Copy link
Contributor

melvyn2 commented Sep 11, 2025

Segfaults on trying to add an SSO account.

Thread 1 ".seafile-applet" hit Breakpoint 1.12, QMessageLogger::fatal (this=this@entry=0x7ffffffec9f0, 
    msg=msg@entry=0x7fffe5d1f0c8 "Cannot mix incompatible Qt library (%d.%d.%d) with this library (%d.%d.%d)")
    at /build/qtbase-everywhere-src-6.9.2/src/corelib/global/qlogging.cpp:879

edit: backtrace at https://gist.github.com/melvyn2/152ea59cd32804f7a189699fff988d09

@pbsbot
Copy link

pbsbot commented Sep 11, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 442070 --extra-nixpkgs-config '{ }'
Commit: e9d2ecdae1711d7d035ed64dca74dbf2ea0d389c


x86_64-linux

✅ 1 package built:
  • seafile-client

@melvyn2
Copy link
Contributor

melvyn2 commented Sep 11, 2025

Segfaults on trying to add an SSO account.

Thread 1 ".seafile-applet" hit Breakpoint 1.12, QMessageLogger::fatal (this=this@entry=0x7ffffffec9f0, 
    msg=msg@entry=0x7fffe5d1f0c8 "Cannot mix incompatible Qt library (%d.%d.%d) with this library (%d.%d.%d)")
    at /build/qtbase-everywhere-src-6.9.2/src/corelib/global/qlogging.cpp:879

edit: backtrace at https://gist.github.com/melvyn2/152ea59cd32804f7a189699fff988d09

Will try updating nixos to see if that's why it's pulling in an old qtsvg

@pbsds
Copy link
Member Author

pbsds commented Sep 11, 2025

yeah i just found the old qtsvg as well in your backtrace

@melvyn2
Copy link
Contributor

melvyn2 commented Sep 11, 2025

Ok looks like it worked once I updated my install to latest unstable. I'm not sure how my system qtsvg library leaked into the client - it feels like that shouldn't be happening. It looks like it was loading the system breeze theme which was pulling in the versions it was built with. Regardless, this was not a user facing issue.

@nixpkgs-ci nixpkgs-ci bot added the 12.approvals: 1 This PR was reviewed and approved by one person. label Sep 11, 2025
@pbsds
Copy link
Member Author

pbsds commented Sep 11, 2025

the correct qtsvg version is being prepended to the qt variables in the wrapper, perhaps some plugin pulled it in?

@pbsds
Copy link
Member Author

pbsds commented Sep 11, 2025

It seems the maintainer has recently dropped maintaining the server and module, i assume they also do not really maintain the client. I'll merge this without waiting 👍

@pbsds pbsds added this pull request to the merge queue Sep 11, 2025
Merged via the queue into NixOS:master with commit 14306b4 Sep 11, 2025
33 of 35 checks passed
@pbsds pbsds deleted the tmp-fix-seafile-client-1757604728 branch September 11, 2025 20:36
@gador gador mentioned this pull request Sep 24, 2025
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: seafile-client

3 participants